Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding consistency with imputations #807

Open
nicolassidoux opened this issue Oct 15, 2024 · 0 comments
Open

Encoding consistency with imputations #807

nicolassidoux opened this issue Oct 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicolassidoux
Copy link
Collaborator

Description of feature

Imputation functions require the data to be encoded. We have two different strategies in ehrapy to deal with that:

  • Throw an exception if the given AnnData is not properly encoded
  • Encode silently and perform the imputation

The second option is problematic because the user cannot control how the data should be encoded.
For the sake of consistency across all the imputation functions, we should modify the imputations that silently encode the data to make it throw an exception instead. We consider it's the user responsability to properly encode his data according to his needs.

@nicolassidoux nicolassidoux added the enhancement New feature or request label Oct 15, 2024
@eroell eroell self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants