Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of DB usage, duplications and redundancy in scarches api #2

Open
farhadmd7 opened this issue Aug 23, 2023 · 1 comment
Open

Lack of DB usage, duplications and redundancy in scarches api #2

farhadmd7 opened this issue Aug 23, 2023 · 1 comment
Assignees
@farhadmd7 @ronskoro

Comments

@farhadmd7
Copy link
Collaborator

farhadmd7 commented Aug 23, 2023 •
edited
Loading

Screenshot 2023-08-23 at 11 22 03 AM

This snippet is from scVI.py -> pretrained_model is ignored here and load_query_data get called again.
Inefficient snippets like that together with hard coded stuff can be found in other scripts as well
@farhadmd7
Copy link
Collaborator Author

Following snippet is from utils.py: Overall lots of these infos for configurations and other purposes can be fetched either from databases in JSON files or recieved from Backend only if needed.
Screenshot 2023-08-23 at 11 32 52 AM

@farhadmd7 farhadmd7 changed the title Duplications, Redundancy in scarches api Lack of DB usage, duplications and redundancy in scarches api Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farhadmd7 farhadmd7

@ronskoro ronskoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@farhadmd7 @ronskoro