Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in about-us page #138

Closed
marcosmenendez opened this issue Mar 2, 2015 · 10 comments
Closed

Changes in about-us page #138

marcosmenendez opened this issue Mar 2, 2015 · 10 comments

Comments

@marcosmenendez
Copy link

Before doing this issue, implement issue #137

We should change the bottom part of the page, taking out the "our way" and including a new section as drawn hereafter with people's avatars linked to their webpage (if they have added it in their profile). It should display pictures of all members that have provided a picture on a pseudo-random order. Every time the user clicks on the "more" button at the bottom of the page, another 20 faces will be shown, up until there are no more faces to show
about us page

With pseudo-random order I mean that in the first set of 20 faces the following should be presented on random order:

  • all faces with "director" seniority
  • at least 7 faces of users with "owner" or "expert owner" seniority
  • as many collaborators as there are up to a maximum of 20-7-directors

If there are for instance 7 directors and 20 collaborators, the first set of faces would include:

  • 7 owners and expert owners
  • 7 directors
  • 6 collaborators

The remaining 14 collaborators will be shown in the following sets, always leaving at least 7 for owners and expert owners. In this case, 13 collaborators would be presented in the second set and 1 in the third.

Pictures or avatars will be clickable if the user has provided a link, and will be surrounded by a frame with a different colour depending on the level of seniority

@marcosmenendez
Copy link
Author

@bodiapz @atrandafir when we upload this issue to preproduction, can we do it on a separate branch? Since we will need some design done I wouldn't like that it blocks the other issues from being deployed.

This affects issue #136 as well

@marcosmenendez
Copy link
Author

  1. super users should not appear in the "people". It doesn't make sense to have a picture of an "admin"
  2. I requested to leave the first paragraph in people, not the second one. Anyway, please put the following test: "TheGoodData is 100% owned by its users. Users become shareholders by simply requesting it. In doing so, TheGoodData interests will always be aligned with yours, which means we’ll never sell out to another company so your data will be safer with us."
  3. I've asked to show 5 pictures per line, not sure if we are showing 4 or 5. Try not to make them smaller, reduce margins first
  4. When clicking on a picture, link should be opened in a new tab, not in the same one
  5. If there is no picture of a certain seniority (eg.Members) we should not show a legend for them at the top
  6. I've said to show the username, but I've changed my mind, please take it out. Sorry

@marcosmenendez
Copy link
Author

@bodiapz I don't understand anything. Pictures of members do not appear anymore in the about page.

Manual levels (collaborator and director) cannot be set either

Give me a call

@bodiapz
Copy link
Contributor

bodiapz commented Mar 27, 2015

Hmm.. I'm not sure what happens on pre-production. Checking...

bodiapz added a commit that referenced this issue Mar 27, 2015
bodiapz added a commit that referenced this issue Mar 27, 2015
bodiapz added a commit that referenced this issue Mar 27, 2015
@bodiapz
Copy link
Contributor

bodiapz commented Mar 27, 2015

I've corrected issues with upload. Problem was in permissions. Now need to upload avatars and then they apear on this page

Seniority levels fixed.

bodiapz added a commit that referenced this issue Apr 1, 2015
bodiapz added a commit that referenced this issue Apr 1, 2015
@marcosmenendez
Copy link
Author

If someone uploads a picture with transparent background, the background is currently converted to black, but it should remain transparent

@JuanMenendezBuitrago
Copy link
Contributor

I also changed the color so they match the site's palette (TGD red, TGD bue, and TGD green instead of regular red,blue and green). There's something about the design that doesn't look quite right though.

@marcosmenendez
Copy link
Author

But are you going to improve it or is it ready to test?

@JuanMenendezBuitrago
Copy link
Contributor

Someone deploy it to pre so I (or anyone) can test it properly. I can't do it myself I don't know why.

@atrandafir
Copy link
Contributor

Deployed to pre finally and tested it. Great, transparency works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants