Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / clean up code #42

Open
JuanMenendezBuitrago opened this issue May 19, 2015 · 1 comment
Open

Refactor / clean up code #42

JuanMenendezBuitrago opened this issue May 19, 2015 · 1 comment

Comments

@JuanMenendezBuitrago
Copy link
Contributor

After all this time developing and adapting the disconnect.me code to suit our needs, some original source code has become unnecessary. In order to avoid too much memory use and to ease understanding of current source code and debugging, some refactoring / clean up tasks should be done.

For instance, port.js is not needed if we're only offering the extension for Chrome and content.js holds code that looks like does nothing in particular. There's the following for clause

for (var i=0; i < 0; i++){
...
}

that obviously, never gets executed (in fact this piece of code has been modified in disconect.me).

Having stopped working with Chango also has made pieces of source code not needed.

Also, I find the writing of variables in upper-case very misleading since generally speaking, one would expect this practice to be used on constant values only... but this is just a mater of personal taste. Maybe we could just leave in upper-case those variables accessible from every javascript file in the extension, like being in a extension scope.

Anyhow, some clean up must be done.

@marcosmenendez
Copy link

ok. Be careful not deleting things that are used or may be used in the future. For instance Chango logic is not used at this point but may be later.

Check with me on a case by cae if you have doubts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants