You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After all this time developing and adapting the disconnect.me code to suit our needs, some original source code has become unnecessary. In order to avoid too much memory use and to ease understanding of current source code and debugging, some refactoring / clean up tasks should be done.
For instance, port.js is not needed if we're only offering the extension for Chrome and content.js holds code that looks like does nothing in particular. There's the following for clause
for (var i=0; i < 0; i++){
...
}
that obviously, never gets executed (in fact this piece of code has been modified in disconect.me).
Having stopped working with Chango also has made pieces of source code not needed.
Also, I find the writing of variables in upper-case very misleading since generally speaking, one would expect this practice to be used on constant values only... but this is just a mater of personal taste. Maybe we could just leave in upper-case those variables accessible from every javascript file in the extension, like being in a extension scope.
Anyhow, some clean up must be done.
The text was updated successfully, but these errors were encountered:
After all this time developing and adapting the disconnect.me code to suit our needs, some original source code has become unnecessary. In order to avoid too much memory use and to ease understanding of current source code and debugging, some refactoring / clean up tasks should be done.
For instance, port.js is not needed if we're only offering the extension for Chrome and content.js holds code that looks like does nothing in particular. There's the following
for
clausethat obviously, never gets executed (in fact this piece of code has been modified in disconect.me).
Having stopped working with Chango also has made pieces of source code not needed.
Also, I find the writing of variables in upper-case very misleading since generally speaking, one would expect this practice to be used on constant values only... but this is just a mater of personal taste. Maybe we could just leave in upper-case those variables accessible from every javascript file in the extension, like being in a extension scope.
Anyhow, some clean up must be done.
The text was updated successfully, but these errors were encountered: