Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and optimize Whitelist request #29

Open
atrandafir opened this issue Nov 18, 2014 · 1 comment
Open

Check and optimize Whitelist request #29

atrandafir opened this issue Nov 18, 2014 · 1 comment

Comments

@atrandafir
Copy link
Contributor

Right now the extension has a local storage where it saves the settings that the user sets for every website he visits.

It's an array containing for every domain the services and their status.

The extension sends this array in a request to the API on every page load so it gets saved on the server side in our database.

I've checked the extension code and all I can find is that the whitelist is sent to the server I think it is never retrieved from the server, it might be an unfinished feature.

So the problem is that this local array can grow big in time, if user changes settings for every website he visits, so we will be sending a big list in every page load. This list is saved on the server and returned to the extension as a confirmation.

The user could have 500 websites in this list and the extension sends all that data to get processed in a single request. This could cause a lot of internal requests to the databse and memory consumption.

So I guess we should either check and optimize this process on both extension and API side, or we can disable it for now if we're not really using it.

I think the goal of this feature was to be able to retrieve the settings when logging in from a different computer.

@marcosmenendez
Copy link

Since this is quiet urgent issue, let's disable it for the time being and leave the issue open to redefine this process properly minimizing server consumption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants