Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container.type = MESOS and networking, marathon 1.4.2 #186

Open
newffy opened this issue Apr 4, 2017 · 2 comments
Open

container.type = MESOS and networking, marathon 1.4.2 #186

newffy opened this issue Apr 4, 2017 · 2 comments

Comments

@newffy
Copy link

newffy commented Apr 4, 2017

when I'm creating app with

container: {
  type: "MESOS"
  docker: {
    image: "...." 
 }
}

and doesn't specify container.docker.network, marathon-python fills "network" with "HOST" value and marathon responds as

ERROR:marathon:Got HTTP 400: {"message":"Invalid JSON","details":[{"path":"/container/network","errors":["Mesos Containerizer does not support network"]}]}
@protetore
Copy link

Same here.

Not only MESOS container type doesn't support docker.network but also on newer versions of marathon you cannot specify container.docker.network when using networks (which is the default behavior now).

Maybe should avoid including this property on the object if not set on MarathonDockerContainer.

@protetore
Copy link

Just submitted a pull request to address this: #218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants