From 17aa2e9f920fcb3b3cba792937360939d80d48f4 Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Sat, 9 Sep 2023 14:55:45 -0400 Subject: [PATCH 1/2] Ignore LNK4217 when linking tests. --- Package.swift | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Package.swift b/Package.swift index 6f98091..5a32ec6 100644 --- a/Package.swift +++ b/Package.swift @@ -13,7 +13,15 @@ let package = Package( // Targets can depend on other targets in this package and products from dependencies. .target(name: "WebDriver", path: "Sources"), .target(name: "TestsCommon", path: "Tests/Common"), - .testTarget(name: "WebDriverTests", dependencies: ["WebDriver", "TestsCommon"]), - .testTarget(name: "UnitTests", dependencies: ["WebDriver", "TestsCommon"]), + .testTarget( + name: "WebDriverTests", + dependencies: ["WebDriver", "TestsCommon"], + // Ignore "LNK4217: locally defined symbol imported" spew due to SPM library support limitations + linkerSettings: [ .unsafeFlags(["-Xlinker", "-ignore:4217"]) ]), + .testTarget( + name: "UnitTests", + dependencies: ["WebDriver", "TestsCommon"], + // Ignore "LNK4217: locally defined symbol imported" spew due to SPM library support limitations + linkerSettings: [ .unsafeFlags(["-Xlinker", "-ignore:4217"]) ])), ] ) From b890b83d774484a65ca89ea8461e53e8066d67ed Mon Sep 17 00:00:00 2001 From: Tristan Labelle Date: Sun, 10 Sep 2023 07:10:26 -0400 Subject: [PATCH 2/2] Fix paren mismatch --- Package.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Package.swift b/Package.swift index 5a32ec6..feed49a 100644 --- a/Package.swift +++ b/Package.swift @@ -22,6 +22,6 @@ let package = Package( name: "UnitTests", dependencies: ["WebDriver", "TestsCommon"], // Ignore "LNK4217: locally defined symbol imported" spew due to SPM library support limitations - linkerSettings: [ .unsafeFlags(["-Xlinker", "-ignore:4217"]) ])), + linkerSettings: [ .unsafeFlags(["-Xlinker", "-ignore:4217"]) ]), ] )