Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intent weather added #74

Closed
wants to merge 3 commits into from
Closed

intent weather added #74

wants to merge 3 commits into from

Conversation

gan3i
Copy link
Contributor

@gan3i gan3i commented Apr 20, 2020 •
edited
Loading

kindly accept the PR. Closes #53

@swapagarwal
Copy link
Member

Needs location entity.

@RohitRathore1
Copy link
Member

@gan3i Needs location entity. Do the necessary changes and resolve the conflicts.

RohitRathore1
RohitRathore1 suggested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@RohitRathore1 RohitRathore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gan3i Tests are failing.
https://travis-ci.org/github/the-vision/jarvis-core/builds/679101952

@gan3i
Copy link
Contributor Author

gan3i commented Apr 24, 2020

Hi @TeAmP0is0N I tried running the solution in gitpot but I am getting bellow error while installing dependencies.
image
I did try with newer version on tensorflow still got the same error.

RohitRathore1
RohitRathore1 suggested changes Apr 30, 2020
View reviewed changes
Copy link
Member

@RohitRathore1 RohitRathore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gan3i You are using version of tensorflow tensorflow==2.1.0 but check our requirement file. We need tensorflow==1.13.2. So, I would suggest you to install tensorflow==2.1.0

@RohitRathore1
Copy link
Member

Use pip install "tensorflow>=1.13.2"

@gan3i
Copy link
Contributor Author

gan3i commented Apr 30, 2020

I get the similar error with 1.13.2, and I am trying this in gitpod, I get the similar error in local as well.
image

@gan3i
Copy link
Contributor Author

gan3i commented Apr 30, 2020

image

@swapagarwal
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RohitRathore1 RohitRathore1 RohitRathore1 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new Intent: Weather
3 participants
@gan3i @swapagarwal @RohitRathore1