Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaction and prompt listeners feel very adhoc and unstructured. #611

Open
Gnuxie opened this issue Oct 10, 2024 · 0 comments
Open

Reaction and prompt listeners feel very adhoc and unstructured. #611

Gnuxie opened this issue Oct 10, 2024 · 0 comments
Labels
development specific Is an issue specific encountered by contributors when trying to develop Draupnir L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first).

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Oct 10, 2024

We create lots of reaction prompt listeners for protections and commands. Some of these are expected to implement parts of interface-manager, such as prompts for promptForDefault, promptForSuggeestions, and promptForConfirmation. Others are just there to implement functionality like in BanPropagationProtection, WatchRoomsOnInviteProtection, and ProtectRoomsOnInviteProtection.

The prompts that implement interface-manager prompts are pretty large and they'd be a pain to implement for someone with a different bot. So we should think about porting the ReactionHandler to interface-manager. This won't need very much, just callbacks for sending reactions to events and rendering DeadDocument with additional context.

The prompts that implement protection functionality really should be rewritten as commands. When their trigger happens (such as a ban or an invitation) they are basically rendering an event with a command continuation prompt. I'm not sure what code needs to be created to accept a command description and create such a prompt.
The other part of this is the command itself which will replace the adhoc prompt listener. This will save us a lot of pain.

We also need to consider replies or some kind of command as a method for reacting to the prompts, and not just reactions.

@Gnuxie Gnuxie added L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first). development specific Is an issue specific encountered by contributors when trying to develop Draupnir labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development specific Is an issue specific encountered by contributors when trying to develop Draupnir L3 Some Users Likelihood P2 Aggravating Priority level T3 Workflow Issue User employs strategies to achieve the task that harm the experience (use minor first).
Projects
Status: No status
Development

No branches or pull requests

1 participant