Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suite test:esm fails under Node 21 #530

Open
3 tasks
colonel-sanders opened this issue Apr 12, 2024 · 2 comments · May be fixed by testdouble/quibble#115
Open
3 tasks

Suite test:esm fails under Node 21 #530

colonel-sanders opened this issue Apr 12, 2024 · 2 comments · May be fixed by testdouble/quibble#115

Comments

@colonel-sanders
Copy link

colonel-sanders commented Apr 12, 2024 •
edited
Loading

Description

Mocking ESM works under Node 20 but not under Node 21

Issue

ES Module mocking does not appear to be working under Node 21.

Environment

  • node -v output: Working under v20.5.0, failing under 21.0.0, failing under v21.6.1
  • npm -v (or yarn --version) output: 9.8.0 under v20.x, 10.2.4 under v21.x
  • npm ls testdouble (or yarn list testdouble) version: 3.20.2

Failing Test

8 out of 11 tests in the test:esm suite are failing under Node 21 but pass under Node 20
@colonel-sanders
Copy link
Author

@giltayar Would really appreciate some of your node ESM loader magic here. Wish I had more background context to knock this one out myself.

@brianzinn
Copy link

Do you support v21 for ESM? I'm having some weird issues with replaceESM.
https://github.com/testdouble/testdouble.js/blob/main/.github/workflows/test.yml#L17

@andreek andreek linked a pull request Sep 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Resolve 3rd party esm without quibbledUrl andreek/quibble
2 participants
@brianzinn @colonel-sanders