Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove_images: true fails to run #338

Open
bmckay210 opened this issue May 22, 2019 · 0 comments
Open

remove_images: true fails to run #338

bmckay210 opened this issue May 22, 2019 · 0 comments

Comments

@bmckay210
Copy link

bmckay210 commented May 22, 2019

When settings remove_images: true in my kitchen file, the images still remain.
Jenkins console log is showing:
unknown flag: --type See 'docker --help'. Usage: docker [OPTIONS] COMMAND

Found that code is issuing a 'docker docker inspect' command by mistake
def image_exists?(state) state[:image_id] && !!docker_command("docker inspect --type=image #{state[:image_id]}") rescue false end
removing the extra docker in the command seemed to fix the issue
def image_exists?(state) state[:image_id] && !!docker_command("inspect --type=image #{state[:image_id]}") rescue false end

This does result in having the whole image inspect output in the log, while that isn't a terrible thing its really not needed, could there be a better way of seeing if the image still exists?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant