Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temperature enum #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use temperature enum #57

wants to merge 1 commit into from

Conversation

kc1212
Copy link

@kc1212 kc1212 commented Oct 19, 2016

fixes #54

match unit {
TemperatureUnit::Celsius => (),
TemperatureUnit::Fahrenheit => temp = temp * (9.0/5.0) + 32.0,
}

Ok(temp)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you move this to inside the match on unit you can drop the mut part from let mut temp =

pub fn read_temperature(&mut self, unit: TemperatureUnit) -> io::Result<f64> {
    // ...

    match unit {
        TemperatureUnit::Celsius => Ok(temp),
        TemperatureUnit::Fahrenheit => Ok(temp * (9.0/5.0) + 32.0),
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Celsius, Fahrenheit enum to the climate crate
2 participants