Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing packages when building termux-tools packages #21176

Open
DevAnDroidCoder opened this issue Aug 19, 2024 · 6 comments
Open

[Bug]: Missing packages when building termux-tools packages #21176

DevAnDroidCoder opened this issue Aug 19, 2024 · 6 comments
Labels
bug report Something is not working properly untriaged

Comments

@DevAnDroidCoder
Copy link

Problem description

I am tried to update termux tools for my app but I got error of missing dependency.

What steps will reproduce the bug?

Build termux-tools package without argument -I

What is the expected behavior?

No response

System information

Run declare -a packages
  declare -a packages
  for repo_path in $(jq --raw-output 'del(.pkg_format) | keys | .[]' repo.json); do
    repo=$(jq --raw-output '.["'${repo_path}'"].name' repo.json)
    if [ -f ./built_${repo}_packages.txt ]; then
      packages="$packages $(cat ./built_${repo}_packages.txt | tr '\n' ' ')"
    fi
  done
  
  if [ true == 'false' ]; then
    NDK=$ANDROID_NDK ANDROID_HOME=$ANDROID_SDK_ROOT ./build-package.sh -a arm $packages
  elif [ -n "$packages" ]; then
    ./scripts/run-docker.sh ./build-package.sh -a arm $packages
  fi
  shell: /usr/bin/bash -e {0}
Running container 'termux-package-builder' from image 'ghcr.io/termux/package-builder'...
Creating new container...
Unable to find image 'ghcr.io/termux/package-builder:latest' locally
latest: Pulling from termux/package-builder
9b857f539cb1: Pulling fs layer
d24da82b95f3: Pulling fs layer
2c4c2fc3faee: Pulling fs layer
de5c9067ef5f: Pulling fs layer
74dee1923210: Pulling fs layer
b7c9d133a0f7: Pulling fs layer
de5c9067ef5f: Waiting
74dee1923210: Waiting
b7c9d133a0f7: Waiting
d24da82b95f3: Verifying Checksum
d24da82b95f3: Download complete
2c4c2fc3faee: Download complete
de5c9067ef5f: Download complete
9b857f539cb1: Verifying Checksum
9b857f539cb1: Download complete
b7c9d133a0f7: Verifying Checksum
b7c9d133a0f7: Download complete
9b857f539cb1: Pull complete
d24da82b95f3: Pull complete
2c4c2fc3faee: Pull complete
de5c9067ef5f: Pull complete
74dee1923210: Verifying Checksum
74dee1923210: Download complete
74dee1923210: Pull complete
b7c9d133a0f7: Pull complete
Digest: sha256:c6ad5a9da424b11a9b5d25837daf73fac6b66d7824909b1420d49b54951c831d
Status: Downloaded newer image for ghcr.io/termux/package-builder:latest
861706f17f687957ffc39cab697ba94de3a2f694636dacced7cb5b9a2c0e1b59
termux - building termux-tools for arch arm...
Downloading https://github.com/termux/termux-elf-cleaner/releases/download/v2.2.1/termux-elf-cleaner
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100  471k  100  471k    0     0  2241k      0 --:--:-- --:--:-- --:--:-- 2241k
ERROR: Package libimobiledevice depends on non-existing package "usbmuxd"
ERROR: Obtaining buildorder failed
Error: Process completed with exit code 1.
@DevAnDroidCoder DevAnDroidCoder added bug report Something is not working properly untriaged labels Aug 19, 2024
@Biswa96
Copy link
Member

Biswa96 commented Aug 19, 2024

I have moved usbmuxd to root-packages directory in 6b81c67 commit because it requires root permission as discussed in #20827. Should usbmuxd be moved back to main packages directory? Or, should all the reverse dependencies of usbmuxd be moved to root-packages directory?

@DevAnDroidCoder
Copy link
Author

I have moved usbmuxd to root-packages directory in 6b81c67 commit because it requires root permission as discussed in #20827. Should usbmuxd be moved to main packages directory? Or, should all the reverse dependencies of usbmuxd be moved to root-packages directory?

What if I revert that commit for myself?
Will it work?

@Biswa96
Copy link
Member

Biswa96 commented Aug 19, 2024

What if I revert that commit for myself?
Will it work?

Probably. My question is for other maintainers.

@twaik
Copy link
Member

twaik commented Aug 19, 2024

@Grimler91 did some changes to make libusb work without root (in separate branch), but I do not know if there any progress.

@agnostic-apollo
Copy link
Member

The build-order.py is already passed all package directories, so OP likely has removed root-packages directory from repo.json and/or from termux-packages git repo.

done<<<$(./scripts/buildorder.py $(test "${TERMUX_INSTALL_DEPS}" = "true" && echo "-i") "$TERMUX_PKG_BUILDER_DIR" $TERMUX_PACKAGES_DIRECTORIES || echo "ERROR")

There might be other main repo packages that depend on packages from root/x11 repo as well. It still could be good policy for core/bootstrap packages to only depend on packages from main repo.

@twaik
Copy link
Member

twaik commented Oct 19, 2024

Should we keep this issue opened or we should close it in prior to #21130?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Something is not working properly untriaged
Projects
None yet
Development

No branches or pull requests

4 participants