Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tt-smi does not fit a standard 80x24 terminal #47

Open
afaerber opened this issue Sep 14, 2024 · 0 comments
Open

tt-smi does not fit a standard 80x24 terminal #47

afaerber opened this issue Sep 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@afaerber
Copy link
Contributor

The box "Compatibility Check" is cut off vertically in a default 80x24 GNOME terminal, hiding the "GS Reset" line and the "Latest SW Versions" box unless the terminal window is resized.

  • Vertical screen space is wasted by a recommendation of Ubuntu 20.04+ (to users of other distros) that line-wraps unnecessarily, due to key alignment with the longest key "WH Reset".
    screenshot of Compatibility Check, with patch for spelling of Arm
  • Driver check will always pass and could be dropped -- compare Allow to use --help and --version arguments without kernel driver loaded #45 checking for the driver in tt-smi main() vs. tt-tools-common get_host_info() always returning a string and thus host_info["Driver"] always evaluating as true.
  • Memory is duplicated between "Host Info" and "Compatibility Check" boxes and could be merged as "Pass (x GB)".
  • In "Host Info" maybe OS and Platform could be combined as, e.g., "Linux (aarch64)"?
    screenshot of Host Info
afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
@afaerber
Shorten recommendation texts
a7df3f2 
Shorten texts from "Recommended" to "Recommend" to avoid a line wrap for
Ubuntu 20.04+ check in tt-smi UI.

Partially addresses tenstorrent/tt-smi#47.

Signed-off-by: Andreas Färber <[email protected]>
afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
@afaerber
Shorten recommendation texts
83378bc 
Change texts returned in system_compatibility() dictionary for "OS"
from "Recommended" to "Recommend".
This avoid a line wrap for Ubuntu 20.04+ check in tt-smi UI.

For consistency also do the same for "Memory".

Partially addresses tenstorrent/tt-smi#47.

Signed-off-by: Andreas Färber <[email protected]>
@afaerber afaerber mentioned this issue Sep 14, 2024
Open
afaerber added a commit to afaerber/tt-tools-common that referenced this issue Sep 14, 2024
@afaerber
Shorten system compatibility recommendation texts
b21e23e 
Change texts returned in system_compatibility() dictionary for "OS"
from "Recommended" to "Recommend".
This avoid a line wrap for Ubuntu 20.04+ check in tt-smi UI.

For consistency also do the same for "Memory".

Partially addresses tenstorrent/tt-smi#47.

Signed-off-by: Andreas Färber <[email protected]>
@milank94 milank94 added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afaerber @milank94