Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ops] Support for clip op (ttnn.clip) #1062

Open
meenakshiramanathan1 opened this issue Oct 25, 2024 · 4 comments
Open

[Ops] Support for clip op (ttnn.clip) #1062

meenakshiramanathan1 opened this issue Oct 25, 2024 · 4 comments
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations
Milestone
[FFE] Bringup

Comments

@meenakshiramanathan1
Copy link

No description provided.

@meenakshiramanathan1 meenakshiramanathan1 added the MLIR Ops Issues related to MLIR dialect ops and their implementations label Oct 25, 2024
@nvukobratTT nvukobratTT added this to the [FFE] Bringup milestone Oct 25, 2024
@mmanzoorTT
Copy link
Contributor

Adding ttnn.clip and ttnn.clamp is in progress. This PR provides an initial end-to-end implementation along with stableHLO to TTIR conversion.

@mmanzoorTT
Copy link
Contributor

PR #1093 is ready for review

This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
@mmanzoorTT
Copy link
Contributor

mmanzoorTT commented Nov 6, 2024 •
edited
Loading

@nvukobratTT @meenakshiramanathan1 ttnn.clip and ttnn.clamp are identical ops; so it is decided to only keep ttnn.clamp (#1093 (comment)). Is ttnn.clamp enough for TT-Forge or ttnn.clip is also required?

@nvukobratTT
Copy link
Contributor

@nvukobratTT @meenakshiramanathan1 ttnn.clip and ttnn.clamp are identical ops; so it is decided to only keep ttnn.clamp (#1093 (comment)). Is ttnn.clamp enough for TT-Forge or ttnn.clip is also required?

We can use clamp as well :)) Once supported, please close this issue so we can map new op on Forge-FE as well :))

This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MLIR Ops Issues related to MLIR dialect ops and their implementations
Projects
None yet
Milestone
[FFE] Bringup
Development

No branches or pull requests
3 participants
@nvukobratTT @meenakshiramanathan1 @mmanzoorTT