Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize_noc_host.hpp uses ARCH_NAME specific include path #14615

Open
blozano-tt opened this issue Nov 2, 2024 · 1 comment
Open

sanitize_noc_host.hpp uses ARCH_NAME specific include path #14615

blozano-tt opened this issue Nov 2, 2024 · 1 comment

Comments

@blozano-tt
Copy link
Contributor

#include "noc/noc_parameters.h"
#include "noc/noc_overlay_parameters.h"

Can we get the required parameters from Hal?

This header file provides the function: tt::watcher_sanitize_host_noc_write() to tt_cluster.cpp.

tt::watcher_sanitize_host_noc_write(soc_desc, {core.x, core.y}, addr, sz_in_bytes);

@blozano-tt
Copy link
Contributor Author

@tt-dma what should we do here?

Put all these parameters behind Hal?

// what's the size of the NOC<n> address space? using 0x1000 for now
#define DEBUG_VALID_REG_ADDR(a) \
( \
(((a) >= NOC_OVERLAY_START_ADDR) && ((a) < NOC_OVERLAY_START_ADDR + NOC_STREAM_REG_SPACE_SIZE * NOC_NUM_STREAMS)) || \
(((a) >= NOC0_REGS_START_ADDR) && ((a) < NOC0_REGS_START_ADDR + 0x1000)) || \
(((a) >= NOC1_REGS_START_ADDR) && ((a) < NOC1_REGS_START_ADDR + 0x1000)) || \
((a) == RISCV_DEBUG_REG_SOFT_RESET_0))

cc: @pgkeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants