Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete convd_host_weights and update all tests using conv2d #14179

Open
LPanosTT opened this issue Oct 23, 2024 · 1 comment
Open

Delete convd_host_weights and update all tests using conv2d #14179

LPanosTT opened this issue Oct 23, 2024 · 1 comment
Assignees

Comments

@LPanosTT
Copy link
Contributor

We have ops prepare_conv_weights_for_ttnn and prepare_conv_bias_for_ttnn that will pre-format convolution weights and biases for conv2d (without pushing them to device). In the previous implementation, you would pass the NHWC weights to ttnn.conv2d and ttnn.conv2d would return the formatted weights/bias on device for you to use in subsequent calls. The two aforementioned ops do this beforehand now.

TASKS

  • ttnn.conv2d is now pybinded to conv2d_host_weights which is the previous conv2d implementation. This needs use conv2d now
  • All tests that use ttnn.conv2d must use ttnn.prepare_conv_weights_for_ttnn and ttnn.prepare_conv_bias_for_ttnn to format weights/biases beforehand.
@shwetankTT
Copy link
Contributor

Waiting for the merge of this PR. #14566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants