Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EmitTypedEvent instead of EmitEvent which is deprecated #353

Open
1 of 4 tasks
bsrinivas8687 opened this issue May 20, 2021 · 1 comment
Open
1 of 4 tasks

Use EmitTypedEvent instead of EmitEvent which is deprecated #353

bsrinivas8687 opened this issue May 20, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v2

Comments

@bsrinivas8687
Copy link
Contributor

Summary

In the latest version of Cosmos SDK (current v0.42.x) type EmitEvent is deprecated so it's better go with EmitTypedEvent

This will be a breaking change for the clients which depends on events

Thoughts?

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz jaybxyz added enhancement New feature or request good first issue Good for newcomers labels May 27, 2021
@jaybxyz
Copy link
Contributor

jaybxyz commented May 27, 2021 •
edited
Loading

Yes. We are aware of the fact that EmitEvent and EmitEvents will be deprecated. Since we're using Cosmos SDK v0.42.4 for the latest develop branch, we decided to follow what they use.

@dongsam dongsam added this to the Long term considerations milestone Jun 14, 2021
@dongsam dongsam modified the milestones: Long term considerations, v2 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v2
Development

No branches or pull requests
3 participants
@dongsam @bsrinivas8687 @jaybxyz