Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with target group name #86

Open
colincoleman opened this issue Aug 3, 2023 · 0 comments
Open

Problem with target group name #86

colincoleman opened this issue Aug 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@colincoleman
Copy link
Contributor

Bug report

After pulling in all the changes to telia-oss to our fork we ran into an issue where using a long name_prefix caused error saying the name of the target group had to be 32 chars or less.

Looking further I see that this commit ab479e2 added a name for the target group.

This was originally intentionally excluded and instead the name_prefix and port number are added as tags. There is still a comment in the code above the addition of the tags as to why this was done.

Steps to reproduce

I haven't tried to confirm that the dynamic name and the create_before_destroy lifecycle policy are still necessary to avoid errors when making changes but I expect they are.

Either way there is an inconsistency in the codebase between the comment and the re-addition of the name parameter

@colincoleman colincoleman added the bug Something isn't working label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant