Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid charts slows down game boot time significantly #20

Open
Electrostats opened this issue Nov 18, 2023 · 0 comments
Open

Invalid charts slows down game boot time significantly #20

Electrostats opened this issue Nov 18, 2023 · 0 comments

Comments

@Electrostats
Copy link

Game Version: TC 1.17B
TrombLoader Version: 2.2.1

Description

TrombLoader added a new feature that prevents charts from loading if they are missing a field or have invalid json format. This is a great feature but it only takes few invalid charts (8 in my case) to make the loading time nearly twice as long.

Reproducible?

Easily. Simply create a faulty chart and copy it a few times then compare loading time.

Issue

For me its not too big of a deal since I can delete the chart that are displayed in the console, but for a regular user they may never notice that some of their charts aren't loading correctly. Its fair to assume most users won't have the bepinex console enabled or won't look at their logs so finding an alternative is probably required for invalid charts.

Example of warning message from invalid chart:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant