Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating webkit2gtk-rs and webkit2gtk-webextension-rs broken by disco gir-files #48

Closed
EPashkin opened this issue Mar 24, 2019 · 4 comments

Comments

@EPashkin
Copy link

cc @GuillaumeGomez, @sdroege, @vhdirk, @antoyo

I will link all related PRs here

@EPashkin
Copy link
Author

@vhdirk, @antoyo I added partial regens, can you check that your webkit application still works with it?
Meanwhile I will finish generation with latest gir.

@vhdirk
Copy link
Contributor

vhdirk commented Mar 24, 2019

@EPashkin So far I can only conclude that it panics in the exact same place it did before (which is why I created the initial issue in the first place). I think @antoyo has a much more complete application to verify webkit-rs.

@EPashkin
Copy link
Author

You meant gtk-rs/webkit2gtk-webextension-rs#40 ?
I thought that you solved it somehow, but gtk-rs/webkit2gtk-webextension-rs#41 not merged.
Webkit2gtk not works on Windows, so I can't help with real errors,
even this patches done without actual linking 😢

@EPashkin
Copy link
Author

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants