Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug in function generate_sub_keys #9

Open
xiekch opened this issue Oct 5, 2019 · 4 comments
Open

A bug in function generate_sub_keys #9

xiekch opened this issue Oct 5, 2019 · 4 comments

Comments

@xiekch
Copy link

xiekch commented Oct 5, 2019

Hi, the code is well-written but I find a bug in the function generate_sub_keys. You don't initialize the key_sets before using it neither before calling the function. Thus the generated keys go wrong in my test.
My suggestion is as follows. Just add memset(key_sets, 0, 17 * sizeof(key_set); in the top of the function.

@xiekch
Copy link
Author

xiekch commented Oct 5, 2019

You initialized the first subkey but it is not enough

@CreazyMouse
Copy link

yes, befer generate_sub_keys should add memset(key_sets, 0, 17 * sizeof(key_set));

@HelloTodayWolrd
Copy link

yes, thank you

@123yongming
Copy link

Bravo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants