Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish --all to detect required order to publish #188

Open
jayvdb opened this issue May 9, 2023 · 1 comment
Open

publish --all to detect required order to publish #188

jayvdb opened this issue May 9, 2023 · 1 comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one

Comments

@jayvdb
Copy link

jayvdb commented May 9, 2023

publish --all fails for https://github.com/Electron100/butane because the order in https://github.com/Electron100/butane/blob/master/Cargo.toml is not the order required to publish. For that project, butane_core has the no dependencies on the other workspace members, while all the others have dependencies on butane_core. So butane_core should be published first, then butane_codegen, etc, etc.

This required order can be determined automatically, and IMO the nature of publish should mean the --all/--workspace flags use this altered ordering , departing slightly for the docs which say

Workspace members will be performed according to the order of the 'packages' fields of cargo metadata.

@taiki-e
Copy link
Owner

taiki-e commented May 13, 2023

I would accept a PR to treat the "publish" subcommand as a special case of --all/--workspace.

@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Development

No branches or pull requests

2 participants