-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary SQL queries #1454
Comments
This query return null if the tag is not found. So the subsequent query has not filter on the tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
demo/src/Controller/BlogController.php
Line 55 in 206f0c9
Hi,
I think a reference application should not promote unnecessary SQL queries. You fetch a tag object from DB then execute another SQL call, why not just passing a tag as a string to the PostRepository instead? Can I offer PR to fix this line to use just one SQL call?
The text was updated successfully, but these errors were encountered: