Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to know the commits or tags of invenio-rdm-app that can successfully install invenio-sword? #52

Open
mhaya opened this issue Jan 16, 2021 · 2 comments

Comments

@mhaya
Copy link

mhaya commented Jan 16, 2021

Hi, I'm trying to install invenio-sword on InvenioRDM while reading https://invenio-sword.readthedocs.io/en/latest/. But I'm failing because of dependency errors. Can I know the commit or tag of invenio-rdm-app that I can check the installation?

@alexdutton
Copy link
Contributor

Hi @mhaya.

invenio-sword was written against Invenio "core" as opposed to InvenioRDM. Development within Invenio has progressed rapidly since the initial work was completed, including a decision to drop the invenio-deposit module that this code extends. Additionally, there wasn't an established metadata schema within the Invenio ecosystem at the time this code was written, so we don't have a SWORD→InvenioRDM metadata mapping as yet.

This does mean that running this code as part of Invenio as it was last June isn't going to be very beneficial for someone who wants to use InvenioRDM going forward, and we will need to do work to move over to the new invenio-records-resources framework and integrate with the invenio-rdm-records schema.

That said, I've fixed a couple of bugs and was able to find a set of requirements versions (https://gist.github.com/alexsdutton/5f0b49ceb8a94e4d54fa8f2fbc1bd7e7) with which the tests pass:

git clone https://github.com/swordapp/invenio-sword.git
cd invenio-sword
wget https://gist.githubusercontent.com/alexsdutton/5f0b49ceb8a94e4d54fa8f2fbc1bd7e7/raw/37d73bc3997ef64997955f6c66d940f945553a35/requirements.txt
python -m venv venv
venv/bin/pip install -r requirements.txt
PYTHONPATH=. venv/bin/pytest

This has been tested with Python 3.7 and Python 3.9.

@mhaya
Copy link
Author

mhaya commented Feb 4, 2021

@alexsdutton Thank you for making it testable. Now, I could run testing code. As you mentioned, InvenioRDM is developing quickly, and I am aware that a WG has recently been set up for InvenioRDM metadata. I think ready to implement SWORD3 in InvenioRDM will take some time. However, in our project(we use Invenio framework now), we wanted to start implementing SWORD3 on a trial basis, and we were trying to run Invenio-sword to understand SWORD3. I tried to reproduce the test environment at that time, but thank you for fixing it so that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants