destructuring should visit children of for stmt or not ?

[stormslowly]

hi @kdy1 :

in destructuring visitor

swc/crates/swc_ecma_compat_es2015/src/destructuring.rs

Lines 129 to 140 in 88a2186

	for_stmt.body = Box::new(Stmt::Block(match &mut *for_stmt.body {
	Stmt::Block(BlockStmt { span, stmts, ctxt }) => BlockStmt {
	span: *span,
	stmts: iter::once(stmt).chain(stmts.take()).collect(),
	ctxt: *ctxt,
	},
	body => BlockStmt {
	stmts: vec![stmt, body.take()],
	..Default::default()
	},
	}));
	}

after transform the first "level" for of stmt, it just skips visiting its children, so the nested for of stmt will be ignored, if we use destructuring separately .

for (const [x,y] of arr1){
  for(const [a,b] of arr2 ){
     //... 
  }
}

is it by design or bug?

my workaround is using for_of transform before destructuring. or destructuring is not supposed to used separately ?

[kdy1]

It‘s a definitely a bug

[stormslowly]

OK, let me fix that