Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JAVA][SPRING-CLOUD] ClientConfiguration always depends on spring-cloud-security and spring-security-oauth2 #6683

Open
wjam opened this issue Oct 14, 2017 · 2 comments · May be fixed by #12186
Open

[JAVA][SPRING-CLOUD] ClientConfiguration always depends on spring-cloud-security and spring-security-oauth2 #6683

wjam opened this issue Oct 14, 2017 · 2 comments · May be fixed by #12186

Comments

@wjam
Copy link

wjam commented Oct 14, 2017

Description

The generated ClientConfiguration class always imports from spring-cloud-security and spring-security-oauth2 even if these imports are unused.

Swagger-codegen version

2.2.3

Swagger declaration file content or url

Example can be found at https://github.com/wjam/swagger-codegen-spring-cloud

Command line used for generation

Maven library used. Configuration is in the GitHub repo mentioned above

Steps to reproduce

Remove the line **/ClientConfiguration.java from the .swagger-codegen-ignore file and run mvn clean compile

Suggest a fix/enhancement

Only include those imports when they are actually required.
@yelhouti
Copy link
Contributor

yelhouti commented Nov 24, 2017 •
edited
Loading

same problem

felhag added a commit to felhag/swagger-codegen that referenced this issue Jun 20, 2023
@felhag
only include imports which are actually required for spring-cloud Cli…
455fd3d 
…entConfiguration generator (closes swagger-api#6683)
felhag added a commit to felhag/swagger-codegen that referenced this issue Jun 20, 2023
@felhag
only include imports which are actually required for spring-cloud Cli…
037bccc 
…entConfiguration generator (closes swagger-api#6683)
@felhag felhag linked a pull request Jun 20, 2023 that will close this issue
Open
4 tasks
@felhag
Copy link

felhag commented Jun 20, 2023

Might be a little late for the party, but I created a pull request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only include imports which are actually required for spring-cloud Cli… felhag/swagger-codegen
3 participants
@wjam @yelhouti @felhag