Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chokidar fallback file watcher no longer works #2539

Open
joshua-cooper opened this issue Oct 20, 2024 · 0 comments
Open

chokidar fallback file watcher no longer works #2539

joshua-cooper opened this issue Oct 20, 2024 · 0 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@joshua-cooper
Copy link

Describe the bug

Since fc2144b the fallback file watcher using chokidar no longer works.

Reproduction

Can reproduce in neovim using this config:

in ~/.config/nvim/after/ftplugin/svelte.lua

vim.lsp.start({
  name = "svelte",
  cmd = { "/path/to/language-tools/packages/language-server/bin/server.js", "--stdio" },
  root_dir = vim.fs.root(0, { "package.json" }),
  capabilities = {
    workspace = {
      didChangeWatchedFiles = false,
    },
  },
})

With this, changes in TypeScript files aren't detected in Svelte files.

Expected behaviour

Changes in TypeScript files should be detected in Svelte files. For example, diagnostics should update.

System Info

  • OS: Linux
  • IDE: NeoVim

Which package is the issue about?

svelte-language-server

Additional Information, eg. Screenshots

Reverting fc2144b fixes this issue, but I'm not sure how to fix it while keeping chokidar v4.

@joshua-cooper joshua-cooper added the bug Something isn't working label Oct 20, 2024
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Oct 31, 2024
dummdidumm pushed a commit that referenced this issue Oct 31, 2024
#2539

chokidar v4 removes all glob support. This migrates fallback watcher and CSS global var to use the ignored config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants