Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tool doesn't work properly if the input/output directory name contains spaces #8

Open
dmajda opened this issue Jan 7, 2013 · 1 comment

Comments

@dmajda
Copy link

dmajda commented Jan 7, 2013

If I run helphelp with an input directory argument containing spaces, it will report lot of errors like this:

Resize picture: mogrify -resize 600x5000 out/quickstart/studio-qs-addrepo-import.png
mogrify: unable to open image `out/quickstart/studio-qs-addrepo-import.png': No such file or directory @ error/blob.c/OpenBlob/2588.
mogrify: unable to open file `out/quickstart/studio-qs-addrepo-import.png' @ error/png.c/ReadPNGImage/3639.
cp: target `out/quickstart/studio-qs-addrepo-overview.png' is not a directory

Similarly for the output directory. When the directories don't contain spaces, everything works fine.

The reason is obviously lack of escaping in shell calls.

@bear454: Would you accept a pull request that will resolve this by using Ruby methods (from FileUtils, etc.) instead of shell calls where possible, and using Cheetah in places where they can't be avoided?

@bear454
Copy link
Member

bear454 commented May 22, 2013

Yeah, no problem. Although, long term, Jekyll is probably a better solution than our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants