Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax test results are not highlighted for syntaxt_test.files #6505

Open
deathaxe opened this issue Oct 4, 2024 · 1 comment
Open

Syntax test results are not highlighted for syntaxt_test.files #6505

deathaxe opened this issue Oct 4, 2024 · 1 comment

Comments

@deathaxe
Copy link
Collaborator

deathaxe commented Oct 4, 2024

Description of the bug

Syntax test runner just requires a file to start with syntax_test to detect it as such. Syntax definition however assumes syntax_test_. Hence results for simple test files like syntax_test.css are not highlighted.

Patch:

--- <Packages>\Default\Syntax Test Results.sublime-syntax
+++ <Packages>\Default\Syntax Test Results.sublime-syntax
@@ -7,7 +7,7 @@
 contexts:
   main:
     # Error location
-    - match: ^([^:\n]*[/\\]syntax_test_[^:\n]*)(?:(:)([0-9]+))?(?:(:)([0-9]+))?(\n)
+    - match: ^([^:\n]*[/\\]syntax_test[^:\n]*)(?:(:)([0-9]+))?(?:(:)([0-9]+))?(\n)
       scope: meta.path.syntax-tests
       captures:
         1: entity.name.filename.syntax-tests

Steps to reproduce

  1. Create a syntax_test.css with failing assertions
  2. Run syntax tests for that file

Expected behavior

All results are highlighted

Actual behavior

No highlighting

Sublime Text build number

4183

Operating system & version

Windows 11

(Linux) Desktop environment and/or window manager

No response

Additional information

No response

OpenGL context information

No response

@BenjaminSchaaf
Copy link
Member

This actually seems to be an inconsistency in the run_syntax_tests command. The docs state tests must start with syntax_test_ and the syntax test runner also finds resources using syntax_test_*. This means the Pascal tests in the packages repository aren't being run by CI currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants