Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser fails to observe some maximum sizes #2

Open
mulkieran opened this issue Apr 3, 2017 · 2 comments
Open

Parser fails to observe some maximum sizes #2

mulkieran opened this issue Apr 3, 2017 · 2 comments

Comments

@mulkieran
Copy link
Member

It succeeds in parsing some dbus signatures which it should fail to parse because because some portion of the signature exceeds the maximum limits.

@mulkieran
Copy link
Member Author

I think that the added complexity is not worth the trouble. Let's just document this fact; that it will parse some signatures that are invalid not because they are ill-formed but because they exceed some maximum, and move on.

@mulkieran
Copy link
Member Author

mulkieran commented Jan 22, 2020

Or we can do a post-check on the parsed value and raise an exception on ones that exceed the limits. The constraints on signatures are all specified, a bit unclearly, in the subheading "Valid Signatures". The first bullet point, we do observe. It's the remaining three that we don't. The problem is that the specification is vague. "The maximum length of a signature is 255." 255 whats? Characters, complete types? Depending on the units, the judgement is very different And because the original documentation didn't specify the units, the only way to find out is to ask, or to read the reference implementation and find out.

Since in order to document this, we'ld have to refer to existing D-Bus documentation that is deeply ambiguous and confusing, we'ld do more harm than good by documenting it, so currently no action is the best course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant