New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getTeams() to Principal contract #447

Open

mulder999 opened this issue Dec 22, 2022 · 0 comments

Labels

mulder999 commented Dec 22, 2022

Rational: Common to ApiKey and UserPrincipal.

OO simplification to avoid this type of ugly code:

            final List<Team> teams;
            if (principal instanceof UserPrincipal) {
                final UserPrincipal userPrincipal = ((UserPrincipal) principal);
                teams = userPrincipal.getTeams();
         
            } else {
                final ApiKey apiKey = ((ApiKey) principal);
                teams = apiKey.getTeams();
            }

nscuro added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment