Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra validation to the atlas texture cache (to prevent a potential crash at startup) #11

Open
MihanDeNoob opened this issue Sep 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@MihanDeNoob
Copy link

full log: https://mclo.gs/E1Y6UlY
crash log: https://mclo.gs/YQxZUnX

So im the perfect candidate to test this mod, since the very essence of this mod is to improve launch times with modpacks xd
Playing with a huge modpack (570+ mods !!!) that been personally assembled and fine tuned by me.

Also, my java arguments, have no idea if some of them can cause issues with this mod:
-XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+AlwaysActAsServerClassMachine -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -XX:AllocatePrefetchStyle=3 -XX:NmethodSweepActivity=1 -XX:ReservedCodeCacheSize=400M -XX:NonNMethodCodeHeapSize=12M -XX:ProfiledCodeHeapSize=194M -XX:NonProfiledCodeHeapSize=194M -XX:-DontCompileHugeMethods -XX:+PerfDisableSharedMem -XX:+UseFastUnorderedTimeStamps -XX:+UseCriticalJavaThreadPriority -XX:+EagerJVMCI -XX:+UseG1GC -XX:MaxGCPauseMillis=37 -XX:+PerfDisableSharedMem -XX:G1HeapRegionSize=16M -XX:G1NewSizePercent=23 -XX:G1ReservePercent=20 -XX:SurvivorRatio=32 -XX:G1MixedGCCountTarget=3 -XX:G1HeapWastePercent=20 -XX:InitiatingHeapOccupancyPercent=10 -XX:G1RSetUpdatingPauseTimePercent=0 -XX:MaxTenuringThreshold=1 -XX:G1SATBBufferEnqueueingThresholdPercent=30 -XX:G1ConcMarkStepDurationMillis=5.0 -XX:GCTimeRatio=99 -XX:G1ConcRefinementServiceIntervalMillis=150 -XX:G1ConcRSHotCardLimit=16 -Xms2G -Xmx6G -XX:+UseLargePages -XX:LargePageSizeInBytes=2m

@MihanDeNoob MihanDeNoob changed the title [Fabric] Crash at the startup (after first launch) [Fabric] Crash at the startup (one second launch, presumably after cache creation) Sep 9, 2024
@Steveplays28
Copy link
Member

Steveplays28 commented Sep 9, 2024

Hi, could you check if your atlas texture cache file is empty (.minecraft/.blinkload/atlas_texture_cache.json)?
Either way, try deleting the entire .minecraft/.blinkload/ folder and relaunching the game. That should fix the issue.

I could add extra validation to the atlas texture cache when I have time.

@Steveplays28 Steveplays28 added the enhancement New feature or request label Sep 9, 2024
@Steveplays28 Steveplays28 changed the title [Fabric] Crash at the startup (one second launch, presumably after cache creation) Add extra validation to the atlas texture cache (to prevent a potential crash at startup) Sep 9, 2024
@MihanDeNoob
Copy link
Author

MihanDeNoob commented Sep 9, 2024

I deleted both mod and config folder and installed the mod again xd
After first launch everything generated correctly, cache.json was not empty but Notepad++ could barely handle it for some reason xd
Second launch was twice as long then without the mod, i forgot to check cache.json but at least the mod didnt crash at startup.
Third launch is when it crashed again at start up and when i checked cache.json it was empty.

@Steveplays28
Copy link
Member

I'll take a look at that issue, that seems new. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants