Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for estimate_null_correlation #98

Open
stephens999 opened this issue Jul 19, 2021 · 0 comments
Open

update docs for estimate_null_correlation #98

stephens999 opened this issue Jul 19, 2021 · 0 comments

Comments

@stephens999
Copy link
Collaborator

can we document what this does by referencing @zouyuxin thesis when this is finalized?
presumably it is using the ad hoc em algorithm there?
does it also return a complete mash fit? ie do you have to run mash on this afterwards?
We should add it to the vignette on dealing with correlations.

I also note the phrasing "under the null" is confusing because it suggests we are assuming the null,
but actually it is the "residual" correlation (ie the correlation after removing effects).
I think the name estimate_null_correlation is fine, but let's clarify the description

zouyuxin added a commit that referenced this issue Jul 20, 2021
zouyuxin added a commit that referenced this issue Jul 20, 2021
zouyuxin added a commit that referenced this issue Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant