Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting starknet_protocolVersion #132

Open
nirtayeb opened this issue Sep 11, 2023 · 6 comments
Open

Supporting starknet_protocolVersion #132

nirtayeb opened this issue Sep 11, 2023 · 6 comments

Comments

@nirtayeb
Copy link

On one of the API documentation pages you mentioned that starknet_protocolVersion is the equivalent of eth_protocolVersion.

Pathfinder appears to have removed it, but Nethermind Juno for example does not.

This method is necessary at Lava Network in order to verify that our 3rd party providers are running the same protocol version (after updates).

What do you suggest we do? is it possible to rollback the removal from pathfinder?

@joshklop
Copy link

starknet_protocolVersion is not part of the current spec, but there will be a starknet_version field in block headers starting in the v0.5 spec, which is currently in a PR.

@Mirko-von-Leipzig
Copy link
Contributor

I think @nirtayeb wants a method to query the RPC version?

@nirtayeb
Copy link
Author

in lava we need to make sure that all rpc providers are:

  • Running the same api method set
  • Each method receives the same signature
  • Each method has the same effect

what is the right version query for that? rpc/starknet/protocol?

@joshklop
Copy link

I see. There isn't an endpoint for querying the RPC spec version, which is distinct from the Starknet protocol version.

Running the same api method set
Each method receives the same signature
Each method has the same effect

Does this need to be done automatically @nirtayeb? It should be possible to see what RPC versions a node supports by looking at the release notes or README (Juno supports v0.4, FWIW).

@odednaor
Copy link

There's a new endpoint starknet_specVersion as part of v0.5.0.

@joshklop
Copy link

@odednaor Only v0.5 providers are technically required to implement this method. After a few more spec releases this shouldn't be a problem, but while v0.5 is new it could be very confusing.

Do you think the method should be moved to a "meta" API that is not versioned, requiring all providers to implement it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants