Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTCEU & Eternal Stella Compatibility Feature Request #387

Open
Ghostipedia opened this issue Jan 8, 2024 · 1 comment
Open

GTCEU & Eternal Stella Compatibility Feature Request #387

Ghostipedia opened this issue Jan 8, 2024 · 1 comment
Labels
Type: Enhancement New feature or request

Comments

@Ghostipedia
Copy link

Is your feature request related to a problem? Please describe.
YES
GregTech:Modern has Recently released a tool refactor which Makes the eternal stella incompatible with most of their tools, and It would be amazing to see Stella support added for their toolsets

Describe the solution you'd like
Presently the Eternal Stella only applies visually to tools (Naming them Eternal, Giving a nice border, etc) But doesn't actually restore/keep the durability Maximum

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Worst Case, when adding an eternal Stella to a GT Tool, it sets the unbreakable flag, as they do that with tools made of "Neutronium," which would also resolve this issue.

Additional context
Add any other context or screenshots about the feature request here.
Some screens of NBT between a Compressed Iron Chestplate (Which works with the Stella) and a Steel hammer (Which does not)
image

@Ghostipedia Ghostipedia added the Type: Enhancement New feature or request label Jan 8, 2024
@mikerooni
Copy link

Imo, setting the unbreakable tag automatically when applying Eternal Stella would be best indeed.
Doing so wouldn't require any additional compatibility changes for each individual mod, as that is a vanilla feature already and can just be hooked into.

For GTCEu Modern specifically, we can't use Minecraft's regular durability system unfortunately, as we need two independent durability values used for separate purposes. We do, however, respect the unbreakable tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants