Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common traits on builders for polymorphism #1553

Open
4 of 5 tasks
JakeWharton opened this issue May 19, 2023 · 2 comments
Open
4 of 5 tasks

Common traits on builders for polymorphism #1553

JakeWharton opened this issue May 19, 2023 · 2 comments

Comments

@JakeWharton
Copy link
Collaborator

JakeWharton commented May 19, 2023

It's really hard to extract code which can operate on two different spec builders.

Off the top of my head, I strongly need:

Other probable inclusions:

I don't think we need a full class hierarchy similar to PSI/FIR, but trait-like interfaces for these fairly primitive operations would be welcome. Maybe named like AnnotatedSpecBuilder, DocumentedSpecBuilder, etc.

@ZacSweers
Copy link
Collaborator

We've done a bit of stuff around Taggable and Context Receivers. Could that be a good starting point?

@JakeWharton
Copy link
Collaborator Author

I've never used either and don't recall their implementations. So, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants