Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit modifier for override parameters in constructor and it's override function #1548

Closed
Omico opened this issue May 16, 2023 · 4 comments · Fixed by #1550
Closed

Omit modifier for override parameters in constructor and it's override function #1548

Omico opened this issue May 16, 2023 · 4 comments · Fixed by #1550
Labels
bug

Comments

@Omico
Copy link
Contributor

Omico commented May 16, 2023 •
edited
Loading

image

Explicit API mode is set as strict.

Also, override function as well.
@Omico Omico changed the title Omit modifier for override parameters in constructor Omit modifier for override parameters in constructor and it's override function May 16, 2023
@Egorand Egorand added the bug label May 16, 2023
@Egorand
Copy link
Collaborator

Egorand commented May 16, 2023

Looks like a bug! Want to send a PR?

@JakeWharton
Copy link
Collaborator

JakeWharton commented May 16, 2023 •
edited
Loading

Dupe of #1301

@JakeWharton JakeWharton closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
@Omico Omico mentioned this issue May 16, 2023
Merged
@JakeWharton JakeWharton reopened this May 16, 2023
@JakeWharton
Copy link
Collaborator

Sorry I read the screenshot and not the title. Thought it was about public members on an internal type.

@Omico
Copy link
Contributor Author

Omico commented May 16, 2023

No worries! Please review it carefully. Hope I didn't mess up the tests.

@kilink kilink mentioned this issue Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit public modifier on override function or constructor parameters
3 participants
@JakeWharton @Egorand @Omico