Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade core framework build to JDK 17 #17778

Closed
spring-projects-issues opened this issue Jul 2, 2015 · 6 comments
Closed

Upgrade core framework build to JDK 17 #17778

spring-projects-issues opened this issue Jul 2, 2015 · 6 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jul 2, 2015

Juergen Hoeller opened SPR-13186 and commented

Resources


Issue Links:

2 votes, 12 watchers

@spring-projects-issues
Copy link
Collaborator Author

Sam Brannen commented

Hi Juergen Hoeller,

I've got some good news...

If you remove the -Werror flag from compileJava.options*.compilerArgs in build.gradle, it is once again possible to start smoke testing against OpenJDK 9 Early Access builds using Gradle 3.0 nightly builds.

$> gradlew wrapper --gradle-distribution-url=https://services.gradle.org/distributions-snapshots/gradle-3.0-20160615000025+0000-bin.zip
$> gradlew -version
$> gradlew clean test

Of course, lots of things don't work, such as: JAXB, XmlBeans, AspectJ, JRuby, our shadow ClassLoader for JPA tests, etc.

As an experiment, however, I was able to get the JAXB support in Spring OXM to compile by declaring the following dependencies in spring-oxm/oxm.gradle.

xjc 'javax.xml.bind:jaxb-api:2.2.11'
xjc 'com.sun.xml.bind:jaxb-core:2.2.11'
xjc 'com.sun.xml.bind:jaxb-impl:2.2.11'
xjc 'com.sun.xml.bind:jaxb-xjc:2.2.11'
xjc 'javax.activation:activation:1.1.1'

So.... happy testing! ;)

p.s., I read elsewhere that the preferred way to reference the current JAXB dependencies (without referencing com.sun.*) is as follows:

  • org.glassfish.jaxb:jaxb-xjc:2.2.11
  • org.glassfish.jaxb:jaxb-runtime:2.2.11

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Jun 19, 2017

Juergen Hoeller commented

For the time being, we're going to stay on a JDK 8 build. Technically we only have a need to build on JDK 9 once we decide to ship module-info descriptors, and it looks like we'll be able to live with Automatic-Module-Name entries (#18289) up until Spring Framework 6.

@spring-projects-issues
Copy link
Collaborator Author

Rostislav Krasny commented

Juergen Hoeller, I think the minimum JDK version for Spring Framework 6 building should be JDK 11 because this is the first Long Term Support (LTS) version of JDK after JDK 8. JDK 9 and JDK 10 had very short term support and are already dead, i.e. they are unsupported by Oracle. I think the title of this Jira ticket should be updated accordingly.

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Good point, once we upgrade the Java baseline for Spring Framework 6, we'll certainly aim for JDK 11+ right away. However, from where we stand right now, this is unlikely to happen before 2021 (when JDK 17 is on the horizon as the next LTS release, providing us with a target support range of two LTS generations of Java again).

@jhoeller
Copy link
Contributor

Repurposing this issue for our JDK 17 baseline in Spring Framewor 6.0, the basics have been covered by a few recent commits already, e.g. through #26901.

bclozel added a commit that referenced this issue Sep 15, 2021
Prior to this commit, the Javadoc task would fail on
`spring-context-indexer` and `spring-instrumentation`. It seems that
missing remote docs or HTTP redirects were failing the process.

This commit removes the missing published Javadocs and updates the
version for the JDK API.

See gh-17778
jhoeller added a commit that referenced this issue Sep 17, 2021
@jhoeller
Copy link
Contributor

Closing this issue for 6.0 M1 since all the basic upgrade is complete.
Further steps towards the Java module system are planned for a later milestone, e.g. #18079.

@jhoeller jhoeller self-assigned this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

2 participants