Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix guideline documentation #40

Open
arturbdr opened this issue Dec 1, 2020 · 1 comment
Open

Fix guideline documentation #40

arturbdr opened this issue Dec 1, 2020 · 1 comment

Comments

@arturbdr
Copy link

arturbdr commented Dec 1, 2020

When following the guideline here:
Spring guides - LDAP

I found out that it's not working because the embedded LDAP server is not starting.
Before checking the complete example (here on the repository) I've debugged the AutoConfiguration class EmbeddedLdapAutoConfiguration
This led me to understand that the the embedded server will only start if the following properties are present in the classpath:

spring.ldap.embedded.ldif=classpath:test-server.ldif
spring.ldap.embedded.port=8389
spring.ldap.embedded.base-dn=dc=springframework,dc=org

This is clear here in the Github example but is missing in the guides of LDAP. Is it possible to improve the guide?

Also, I believe it would be nice to put a log.debug or even a log.info when the embedded server is started and in which port it has started.

@Buzzardo
Copy link
Contributor

This is a good first issue for someone who wants to start contributing.

I would skip the log.debug or log.info bit, though, as they lead to a lot of output. At most, I would mention those options but not turn them on by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants