Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpanInjector migration guide #981

Closed
marco-primiceri opened this issue May 16, 2018 · 3 comments
Closed

SpanInjector migration guide #981

marco-primiceri opened this issue May 16, 2018 · 3 comments

Comments

@marco-primiceri
Copy link

Hi There,

It seems that the SpanInjector has been removed in M6 although I could not find anything in the migration guide about how to migrate to a new implementation (if any) or whether the feature has been removed entirely (hence it is now using Brave instead).

Also, do you mind updating the docs which still say:

Sleuth includes default logic to join a trace across HTTP or messaging boundaries. For example, HTTP propagation works over Zipkin-compatible request headers. This propagation logic is defined and customized through SpanInjector and SpanExtractor implementations.

Thanks!
Marco

@marcingrzejszczak
Copy link
Contributor

@marco-primiceri
Copy link
Author

Thanks for that Marcin, much appreciated!

@marcingrzejszczak
Copy link
Contributor

No problem, great catch! I haven't noticed that this piece is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants