Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpms #2108

Open
xenoterracide opened this issue May 9, 2024 · 5 comments
Open

jpms #2108

xenoterracide opened this issue May 9, 2024 · 5 comments

Comments

@xenoterracide
Copy link

please add jpms support, at least automatic modules for now. However, this issue or another issue should be added for full module-info at sometime in the future. Referencing this upstream spring issue (specifically comment) which shows all of the dependencies that could be included via the code generator spring-projects/spring-framework#18079 (comment)

@spencergibb
Copy link
Member

We will follow the lead of spring-framework regarding this.

@xenoterracide
Copy link
Author

xenoterracide commented May 9, 2024

Currently spring framework is using automatic modules. I flagged this because it doesn't appear to have any automatic module. At least not according to that report.

To catch up you should add an automatic module today so that people who want to use JPMS can compile against spring-cloud-contract. I'm not really expecting a full module-info at this time, that's the long term ideal though.

@marcingrzejszczak
Copy link
Contributor

Hey, any idea how to generate the automatic module in Maven?

@xenoterracide
Copy link
Author

I do not. Although I'm not sure it's worth generating because I think it's only one line in the manifest.mf.

@marcingrzejszczak
Copy link
Contributor

Related PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants