Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

Make Quick Search dialog not modal #6

Closed
paulvi opened this issue Dec 31, 2013 · 7 comments
Closed

Make Quick Search dialog not modal #6

paulvi opened this issue Dec 31, 2013 · 7 comments

Comments

@paulvi
Copy link

paulvi commented Dec 31, 2013

in Quick Search for Eclipse http://marketplace.eclipse.org/content/quick-search-eclipse
please make dialog not modal (and not close by default),
just like Ctrl+F in Eclipse or MS Word.

Also could it have option to push results to Eclipse Search View ?

@fmjrey
Copy link

fmjrey commented May 9, 2014

I also would enjoy it even more if it wasn't modal.

@kdvolder
Copy link
Contributor

kdvolder commented May 9, 2014

Also could it have option to push results to Eclipse Search View ?

That would be rather hard to do because it doesn't really use Eclipse search infrastructure. Besides the whole point of implementing it is because we don't like how the Eclipse search view displays results.

Making the dialog non-modal sounds like a good idea and is probably feasible. Maybe more of floating window that could be pinned down.

Problem is finding the time to work on this :-)

@kdvolder
Copy link
Contributor

Thinking about implementing something that might be what you want (or not). If you have any thoughts on what you had in mind exactly and/or whether what I'm proposing to implement, feel free to comment here or on the Jira issue:
https://issuetracker.springsource.com/browse/STS-3989

@paulvi
Copy link
Author

paulvi commented Dec 10, 2014

JIRA takes a 1-3 minutes to open in China

And don't know how to let Pivotal people know

similar to codenvy-legacy/sdk#45

@spudtheimpaler
Copy link

@kdvolder The Jira issue to which you linked can not be commented on, so I will comment here.

Personally I understand the downsides to modality, but for what this is used for I can't see a better alternative to use in a view. Personally I am happy for it to be left how it is.

@kdvolder
Copy link
Contributor

We finally did this :-) But looks like we have this older issue still floating around.

See: spring-projects/sts4#189

@martinlippert
Copy link
Contributor

This will ship as part of the upcoming STS 3.9.8 and STS 4.2.0 releases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants