Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a possibility to leave comments in connection to a text segment/tag #86

Open
elenavolodina opened this issue Aug 21, 2018 · 8 comments

Comments

@elenavolodina
Copy link
Member

Let's say we have something we don't know how to handle that and we assign a tag "OBS!" We would also want to explain why "OBS" is there.

@arildm
Copy link
Member

arildm commented Oct 10, 2018

Should the comment be compulsory for OBS?

Are there any other tags that should allow (or enforce) comments? sensitive?

@arildm
Copy link
Member

arildm commented Jan 18, 2019

As discussed in yesterday's meeting, the idea is that a comment text field should be visible, as a separate widget (below the spaghetti area, for example) for each OBS label added. The data structure should be extended with a list of comments.

Some follow-up questions:

  1. How to reference between a comment and an OBS-labeled edge?
  • Perhaps sequentially, so the first OBS-labeled edge corresponds to the first comment, etc.
  • Alternatives include using numerical labels, or edge ids.

@cajosc Do you have any input on where, in the data structure, comments should live?

  • As a label: Probably not suitable, because a comment could be long and we don't want it displayed like any other label in the spaghetti.
  • As another property in the Graph type beside source, target and edges.
  • As another property outside the Graph structure. Requires API change in the portal, I suppose?

@cajosc
Copy link
Contributor

cajosc commented Jan 18, 2019

@arildm How about a new field on the label, e.g. comment? It seems reasonable to store comments as close to the labels as possible, if they can't be stored in them.

Note (for self) that this requires a small change in the code that exports anonymized essays from the kiosks to the portal.

@arildm
Copy link
Member

arildm commented Jan 23, 2019

Now implemented on https://spraakbanken.gu.se/swell/dev/

When OBS! is added, a comment field appears. The comment is visible and editable when the OBS-labeled edge is selected. It is deleted if the tag is removed.

@arildm arildm closed this as completed Jan 29, 2019
@elenavolodina
Copy link
Member Author

A little adjustment needs to be made: "OBS"-comment text field should rather come before all the validation warnings, see the picture:

skarmavbild 2019-01-29 kl 19 50 07

@arildm
Copy link
Member

arildm commented Jan 30, 2019

Gunlög is having problems with comments disappearing.

@arildm arildm reopened this Jan 30, 2019
@arildm
Copy link
Member

arildm commented Jan 30, 2019

Also, we want to split the OBS label into two. Currently, there is a validation rule that prevents saving as done when there is are OBS labels. Sometimes, we want to save as done but keep the comment. So maybe reassign the comment functionality to a new Comment label.

@arildm
Copy link
Member

arildm commented Jan 30, 2019

"OBS"-comment text field should rather come before all the validation warnings

Fixed in f3a8460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants