Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudonymization for age_string #106

Closed
arildm opened this issue Oct 22, 2018 · 10 comments
Closed

Pseudonymization for age_string #106

arildm opened this issue Oct 22, 2018 · 10 comments

Comments

@arildm
Copy link
Member

arildm commented Oct 22, 2018

Continued from #74

we need to consider how to handle the replacement. Maybe add an option to manually add a number in digits (the original age for intermediate span calculation), or directly a span? E.g. for "Jag är arton år" we replace "arton" with @age_string:15-21 - or something like that? What is feasible to do?

@cajosc
Copy link
Contributor

cajosc commented Nov 23, 2018

Why not edit source text, replace "arton" with the number 18 and then add label?

(Me and @elenavolodina have talked about this and think it's fine.)

@elenavolodina
Copy link
Member

If we let assistants replace an age-string with a number, but label with < age-string > - could we maybe render the same way as in < age-number > but spell the number out? This way the rendered text would correspond to the original better.

@arildm
Copy link
Member Author

arildm commented Apr 18, 2019

Fixed in 2bf27e4. Now, the numeric label is interpreted differently for age_string. The number generated will be close to the numeric label.

Screenshot 2019-04-18 at 10 30 45

Not pushed to kiosk yet.

@arildm
Copy link
Member Author

arildm commented Apr 18, 2019

Now pushed to kiosk

@arildm arildm closed this as completed Apr 18, 2019
@arildm arildm reopened this Apr 24, 2019
@arildm
Copy link
Member Author

arildm commented Apr 24, 2019

  • Should not keep the original age as a label

@arildm
Copy link
Member Author

arildm commented Apr 29, 2019

Suggestion: add a "pseudonymization argument" widget where the user can enter the numeric age

@arildm
Copy link
Member Author

arildm commented Apr 30, 2019

The new solution replaces the function of the input field, if age_string has been added, so that any number entered is not used as another label, but only as an argument to the pseudonymizer.

With the following example, test it by dragging the image into the dev instance of the editor, selecting the "arton" edge, adding the age_string label and then entering "18" in the "Extra input" field.

@elenavolodina
Copy link
Member

This is perfect! I like the solution - very easy and elegant! Did you push it to kiosk? We need also to inform Lisa for her pseudonymization work.

Some comments:

  1. Dragging exe did not work for me - can we test that together?
  2. By handling < age-string > that way we do not add a numeric label to the anonymization label, but this is probably not important...

@elenavolodina
Copy link
Member

@arildm Could you, please, replace all mentions of "anonymization" with "pseudonymization" in the Svala-tool?

  • in the view name (Svala pseudonymization)
  • in the link (menu on the right)
  • in the link to guidelines (menu on the right)

@arildm
Copy link
Member Author

arildm commented May 3, 2019

I will check with Lisa.

I created #152 (drag-and-drop bug) and #151 ("pseudonymization") as follow-ups from your comments, @elenavolodina.

@arildm arildm closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants