Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand-craft visualization of lettuce datasets #2

Closed
3 of 5 tasks
jjmata opened this issue Feb 7, 2017 · 3 comments
Closed
3 of 5 tasks

Hand-craft visualization of lettuce datasets #2

jjmata opened this issue Feb 7, 2017 · 3 comments
Assignees
Milestone

Comments

@jjmata
Copy link
Member

jjmata commented Feb 7, 2017

The GeoJSON datasets are pretty much ready: one, two, three (we have something we can work with already, but @ivanprado is going to re-run the holes one to get us better accuracy), so the idea is to:

Did I miss anything as discussed, @apercas or @ivanprado?

@jjmata jjmata changed the title Hand-craft visualization of lettuce Hand-craft visualization of lettuce datasets Feb 7, 2017
@apercas
Copy link

apercas commented Feb 19, 2017

I didn't want to check them out but we have already imported the lanes, holes and fields dataset and we can add a heatmap with the holes with no effort.

The widget issue that is driving me crazy in detail is:
How to reproduce:
-Both locally or on alpha: Add a widget (whichever you like)
-Try to display it
Cause:
-Failing while routing (for some reason the http://tileo.localhost/ becomes http://dev.localhost.lan:8181)
Where to see it:
-Check the right hand column
Status:
-I first checked the app_config YAML file so it matches the preferred route. It didn't change anything at all (meaning: it changes the regular route but for this bug it did't apply).
-I started debugging using Chrome DevTools adding a breakpoint in the XHR and then scaled up until I spotted URL change itself on model-updater.js L166:

var dataviewMetadata = windshaftMap.getDataviewMetadata(dataviewModel.get('id'));

-I checked the Windshaft config and the output there and both are correct
-I couldn't test it but my guess is that the content of each item of the DataView collection is wrong (meaning, poor URL) from the its creation.

@jjmata
Copy link
Member Author

jjmata commented Feb 23, 2017

I found the reason for the widget issue*, it's a missing configuration value as we suspected (a new one that we are missing) on the Windshaft side. It dates back to November (so recent in the grand scheme of things), here is the commit:

And the historical background directly from @rochoa's mouth :-)

(*) I didn't step into it via debugger, but I believe the fallback URL was being assembled here.

@apercas apercas added this to the april3rd milestone Mar 6, 2017
@jjmata
Copy link
Member Author

jjmata commented Mar 29, 2017

This was accomplished and demo'ed to Grupo Gs a few days back. Closing.

@jjmata jjmata closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants