Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map's should export values as optional #283

Open
oscartbeaumont opened this issue Sep 18, 2024 · 0 comments
Open

Map's should export values as optional #283

oscartbeaumont opened this issue Sep 18, 2024 · 0 comments

Comments

@oscartbeaumont
Copy link
Member

oscartbeaumont commented Sep 18, 2024

HashMap<HotkeyAction, Hotkey> should be { [key in HotkeyAction]?: Hotkey } instead of { [key in HotkeyAction]: Hotkey }

This is because if is an enum HotkeyAction not all of it's variants have to exist in the map.

Context: https://discord.com/channels/@me/813276814801764382/1285872494682832990

@oscartbeaumont oscartbeaumont changed the title Map's should export as optional Map's should export values as optional Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant