Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop thiserror from crates #251

Open
oscartbeaumont opened this issue Jun 24, 2024 · 0 comments
Open

Drop thiserror from crates #251

oscartbeaumont opened this issue Jun 24, 2024 · 0 comments

Comments

@oscartbeaumont
Copy link
Member

oscartbeaumont commented Jun 24, 2024

I think it's worth just manually implementing them to avoid the macros and extra dependencies.

It's a great crate and the impls we want will be the same as it generates. We are just a library and the idea is to get Specta as early in the build process as possible.

This is especially true when we have a macros feature which wouldn't technically disable macros if we stick with using thiserror.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant