Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection errors are not exposed #374

Open
pimterry opened this issue Jul 7, 2020 · 0 comments · May be fixed by #375
Open

Connection errors are not exposed #374

pimterry opened this issue Jul 7, 2020 · 0 comments · May be fixed by #375

Comments

@pimterry
Copy link

pimterry commented Jul 7, 2020

connection.on('error', function () {
socket.destroy()
})

Here ⬆️ the server listens for connection errors, and then silently shuts down the socket.

It doesn't provide any easy way to listen for these errors though, like Node HTTP/1.1's clientError event or HTTP/2's sessionError event, so code using node-spdy never knows that this has happened.

This can be useful for error reporting and monitoring. I'm going to work around this manually in my application, but built-in support would be useful. Are you be open to a PR adding this?

@pimterry pimterry linked a pull request Jul 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant