Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source catalog / tweakreg PSF accuracy #1460

Open
schlafly opened this issue Oct 16, 2024 · 0 comments
Open

Improve source catalog / tweakreg PSF accuracy #1460

schlafly opened this issue Oct 16, 2024 · 0 comments
Assignees

Comments

@schlafly
Copy link
Collaborator

I inadvertently left a (large!) fudge factor in the requirement testing tweakreg fit accuracy:
https://github.com/spacetelescope/romancal/blob/main/romancal/regtest/test_tweakreg.py#L80
The factor of 100 on this line should be deleted.

When we delete that, we will start failing tests. The astrometric RMS we are getting in tweakreg is not so bad, so it's unclear why there is a large shift. It appears to be almost entirely a constant shift. One possibility is that this came in with an update to WebbPSF; romancal uses new WebbPSF PSFs, while the L1s were generated using older PSFs. We should see what's the ultimate cause of the discrepancy there and remove the spurious factor of 100.

@schlafly schlafly self-assigned this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant